efficiency

Guest

basically i made a really long script and need to make more efficient.....

instead of saying :

etc etc etc..... 16 times

i would add another tag and say

Code:: model = script.Parent
parts = model:FindFistChild.ClassName("Part")

parts.Transparency = 0

wud tht work?

Administrator Posts : 1081 Join date : 2010-12-09 Age : 26

Code:: model = script.Parent
parts = model:GetChildren()
for _,part in ipairs(parts)
if (part:IsA("BasePart")) then
part.Transparency = 0
end
end

Guest

i got 1 other now......

Code:: model = script.Parent
part = model:GetChildern
parts = part.ClassName = ("Part")
parts.Transparency = 0

again wud tht work?

Administrator Posts : 1081 Join date : 2010-12-09 Age : 26

nope.

Expert Scripter Posts : 393 Join date : 2011-01-17

is this what your trying to do?

Code:: for part in ipairs(script.Parent:GetChildren()) do
if part.ClassName == "Part" then
part.Transparency = 0
end
end

the value of a key that is a table, since even parts on roblox are tables, is table:(%UniqueID%). you do know that right, blueymaddog?

Subject: Re: efficiency January 25th 2011, 5:44 am

Code:: local model = workspace.model:GetChildren()

for x=1, #model do
if model[x].className == "Part" then
model[x].Transparency = 0.5
end
end

Expert Scripter Posts : 393 Join date : 2011-01-17

blueymaddog?

Administrator Posts : 1081 Join date : 2010-12-09 Age : 26

yes supernaplam?

Expert Scripter Posts : 393 Join date : 2011-01-17

the value of a key that is a table is a unique id of how where the table is stored. you know that right?

Administrator Posts : 1081 Join date : 2010-12-09 Age : 26

Yes. and the ID changes all the time. Try printing the same table twice. :P

Subject: Re: efficiency January 27th 2011, 7:04 pm

It will only change if you change it.

Administrator Posts : 1081 Join date : 2010-12-09 Age : 26

print _G twice. it prints different id's 0.o

Expert Scripter Posts : 393 Join date : 2011-01-17

anyway, here's what you put

Code:: model = script.Parent
parts = model:GetChildren()
for _,part in ipairs(parts)
if (part:IsA("BasePart")) then
part.Transparency = 0
end
end

you contradicted yourself

Administrator Posts : 1081 Join date : 2010-12-09 Age : 26

lolwhatiswrongwithmyscriptthatyourtryingtopointput?

Administrator Posts : 878 Join date : 2010-07-30

Couldn't you just combine those two variables anyway? :D Felt like jumping in

Expert Scripter Posts : 393 Join date : 2011-01-17

what i think is wrong is that you accessed part instead of _.

Administrator Posts : 1081 Join date : 2010-12-09 Age : 26

mine is fine. for [name of the index it's iriterating through], key in ipairs(table) do

Expert Scripter Posts : 393 Join date : 2011-01-17

i thought part was a key, not an index

Administrator Posts : 1081 Join date : 2010-12-09 Age : 26

key is the value index is the name of where the key is stored in the table.

Expert Scripter Posts : 393 Join date : 2011-01-17

i mean i thought part was an index, not a key. you are accessing the index. arent you supposed to access the key?

Administrator Posts : 1081 Join date : 2010-12-09 Age : 26

sorry, I think I mislead u. when I said index I mean the index name and when I said key I meant the index. I think that makes more sense now.

Got a really good idea? Post it in projects and it might show up here!